Everybody has his own pet peeves. I have one on teaching guitar that I want to share with you, because it can save you a lot of time and effort. Here it is: I think that if you know more than two scale patterns and you have never improvised on them, you are losing your time. The BEST way to learn a scale pattern is not to play it up&down for hours and hours and hours. The best way is to improvise using this scale with an appropriate backing track. This way you are going to learn how the scale sounds, how to make actual music with it, and when you can use it or not.
Consider that most of the most famous guitar solos have been played on the same scale (minor pentatonic) and you will realize that it's better to know a few scales in depth rather than 200 patterns that you never improvised with. Of course, if you want to know 200 patterns in depth, that's even better :-)
My advice? If you are self-taught, every time you want to learn a new scale pattern, make it a point to improvise with it as soon as possible. As usual a good teacher can help you doing that. On the other hand, if you do have a teacher and he's making you learn pattern over pattern and never makes you improvise on them... well, ditch him and find a GOOD teacher.
